Invert reference type null checks #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accidentally submitted this in the middle of writing the description. Now ready to review :) |
surma
force-pushed
the
reftype-nullcheck-fix
branch
from
2d96d57 to
15d7745
Compare
GitHub has draft pull requests. |
MaxGraey
reviewed
Mar 7, 2021
I know, thank you. I just pressed Cmd+Enter by accident. |
MaxGraey
reviewed
Mar 7, 2021
Co-authored-by: Max Graey <[email protected]>
Co-authored-by: Max Graey <[email protected]>
surma
force-pushed
the
reftype-nullcheck-fix
branch
from
5cf3492 to
be87ecd
Compare
dcodeIO
reviewed
Mar 7, 2021
MaxGraey
reviewed
Mar 7, 2021
Co-authored-by: Daniel Wirtz <[email protected]>
|
Thanks again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is my first PR digging into the compiler and I’m not 100% sure I did this right. Please point out anything you’d like changed.)
I was playing with reference types and notices that code like this behaves exactly inverted:
It seems like the logic in
makeIsTrueishwas just usingref.is_null, which would explain the inversion. This PR flips thats logic.However, I couldn’t run the full tests as the tests still failed with
Feature 'gc' is not enabled.despite settingASC_FEATURES="*". I guess that is the world of experimental features.PTAL!